fix: set an ASG's launch template version to an explicit version to automatically trigger instance refresh #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashims
changed the title
bashims
changed the title
|
@bashims can you please rebase your branch from master. |
automatically. This will ensure that an instance refresh will be triggered whenever the launch template changes.
bashims
force-pushed
the
fix-1365-refresh-on-template-change
branch
from
4641c6c
to
fb61961
Compare
bashims
changed the title
|
@barryib rebased |
2 tasks
barryib
reviewed
May 19, 2021
added 2 commits
May 19, 2021 10:09
the aws_autoscaling_lifecycle_hook.
default launch_template version. Signed-off-by: Benjamin Ash <[email protected]>
bashims
force-pushed
the
fix-1365-refresh-on-template-change
branch
from
604fb9a
to
0cdc35d
Compare
barryib
approved these changes
May 19, 2021
barryib
changed the title
|
Thanks again @bashims for your great work. |
This was referenced May 19, 2021
|
@barryib do you think you might be able to include this fix in a patch release today? |
Yep. I'll do that tonight. |
|
v16.1.0 is released. |
barryib
added a commit
to barryib/terraform-aws-eks
that referenced
this pull request
May 20, 2021
…utomatically trigger instance refresh (terraform-aws-modules#1370) NOTES: Set an ASG's launch template version to an explicit version automatically. This will ensure that an instance refresh will be triggered whenever the launch template changes. The default `launch_template_version` is now used to determine the latest or default version of the created launch template for self-managed worker groups. Signed-off-by: Benjamin Ash <[email protected]> Co-authored-by: Thierno IB. BARRY <[email protected]>
ArchiFleKs
pushed a commit
to ArchiFleKs/terraform-aws-eks
that referenced
this pull request
Jun 1, 2021
…utomatically trigger instance refresh (terraform-aws-modules#1370) NOTES: Set an ASG's launch template version to an explicit version automatically. This will ensure that an instance refresh will be triggered whenever the launch template changes. The default `launch_template_version` is now used to determine the latest or default version of the created launch template for self-managed worker groups. Signed-off-by: Benjamin Ash <[email protected]> Co-authored-by: Thierno IB. BARRY <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set an ASG's launch template version to an explicit version automatically. This will ensure that an instance refresh will be
triggered whenever the launch template changes.
PR o'clock
Description
In order to properly trigger instance refresh whenever a launch template is modified the version of the template must be updated in the autoscaling group. Previous versions of this module only supported setting the template version manually. This PR adds a new feature that will either set the version to the latest (real) version or the default (real) version with the use of the boolean
use_latest_version. It is still possible to pin a specific version of template by settinglaunch_template_versioninworker_groups_launch_template. The defaultlaunch_template_versionis ignored in the case of autoscaling group launch template, however it is preserved for thenode_groupcase.This PR also adds the ability to optionally update the default version for any autoscaling group launch template.
Fixes: #1365 #1315 #1293
Checklist