feat: Tags passed into worker_groups_launch_template extend var.tags for the volumes #1397
Conversation
…e_at_launch=false So if the propagation of the tag to Amazon EC2 instances launched via the ASG is disabled, the volumes don't get tag as well
| { | ||
| for tag in lookup(var.worker_groups_launch_template[count.index], "tags", local.workers_group_defaults["tags"]) : | ||
| tag["key"] => tag["value"] | ||
| if tag["key"] != "Name" && tag["propagate_at_launch"] | ||
| } |
There was a problem hiding this comment.
Can you please follow the instance tag specifications tag extension ? It would be nice to have the same behavior across all tags in launch template.
There was a problem hiding this comment.
Thanks a lot for such a quick response.
Unfortunately, there is a bit different approach for the instance tagging is already defined with this change #1092 and this improvement #1095
As a result, EC2 instances can get additional tags via the propagate_at_launch option in ASG. If I rewrite this in the same way as for volumes tagging via tag_specifications we'll lose the feature to tag instances created with launch configuration. Is it ok for us? If yes, I'm happy to do this.
Anyway, I can add this tags extension to the instances tag specification and it'll override the approach in ASG tagging, but it could lead to ambiguity in the future.
Please, share your thought regarding this?
There was a problem hiding this comment.
@barryib, do you still want me to make a change for the instances tagging with overriding the existing approach?
There was a problem hiding this comment.
Hi, @barryib . Sorry, maybe I misunderstood you. Do you mean that I should implement tagging of the volumes in the same way as tagging of the instances is already done?
Or should I modify the existing approach of the instances tagging in the same way as I've proposed to do for volumes?
We've really interested in the delivery of this feature, so could you advise, please, what should be done to get it merged?
|
Hi folks, please, let me know what should be done to bring this change to release? |
|
@barryib could you give any feedback, please? I'm open to any suggestion to give this change a life. |
|
@barryib, our team looks forward to your response. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
This change brings an option to extend
var.tagsfor the EBS volumes with tags that are passed intovar.worker_groups_launch_templateorvar.workers_group_defaults.This resolves #1396.
The main use case for this to separate resources costs between owners for shared cluster usage.
Since tagging of EC2 instances via
var.worker_groups_launch_templateorvar.workers_group_defaultsis already done, I assume it should be useful to tag volumes as well.As a result of this change, tags from
var.worker_groups_launch_templatewill override tags invar.workers_group_defaultsif any and then will be merged withvar.tagsfor EBS volumes of ASG created via launch templates.Checklist