feat: Add tags to EKS created cluster security group to match rest of module tagging scheme #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module tagging scheme
antonbabenko
pushed a commit
that referenced
this pull request
Mar 24, 2022
## [18.14.0](v18.13.0...v18.14.0) (2022-03-24) ### Features * Add tags to EKS created cluster security group to match rest of module tagging scheme ([#1957](#1957)) ([9371a29](9371a29))
|
This PR is included in version 18.14.0 🎉 |
| @@ -59,6 +59,14 @@ resource "aws_eks_cluster" "this" { | |||
| ] | |||
| } | |||
|
|
|||
| resource "aws_ec2_tag" "cluster_primary_security_group" { | |||
| for_each = { for k, v in merge(var.tags, var.cluster_tags) : k => v if var.create } | |||
There was a problem hiding this comment.
Using local.create is better but var.create is ok, too. :)
There was a problem hiding this comment.
ah shoot, my bad - I forgot that one. I'll get it on the next change
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
… module tagging scheme (terraform-aws-modules#1957)
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
## [18.14.0](terraform-aws-modules/terraform-aws-eks@v18.13.0...v18.14.0) (2022-03-24) ### Features * Add tags to EKS created cluster security group to match rest of module tagging scheme ([terraform-aws-modules#1957](terraform-aws-modules#1957)) ([9371a29](terraform-aws-modules@9371a29))
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
… module tagging scheme (terraform-aws-modules#1957)
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
## [18.14.0](terraform-aws-modules/terraform-aws-eks@v18.13.0...v18.14.0) (2022-03-24) ### Features * Add tags to EKS created cluster security group to match rest of module tagging scheme ([terraform-aws-modules#1957](terraform-aws-modules#1957)) ([9371a29](terraform-aws-modules@9371a29))
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
## [18.14.0](terraform-aws-modules/terraform-aws-eks@v18.13.0...v18.14.0) (2022-03-24) ### Features * Add tags to EKS created cluster security group to match rest of module tagging scheme ([#1957](terraform-aws-modules/terraform-aws-eks#1957)) ([eaf4c38](terraform-aws-modules/terraform-aws-eks@eaf4c38))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*projectscompleteexample