fix: Default to cluster version for EKS and self managed node groups when a cluster_version is not specified
#1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when a `cluster_version` is not specified
antonbabenko
pushed a commit
that referenced
this pull request
Mar 24, 2022
### [18.14.1](v18.14.0...v18.14.1) (2022-03-24) ### Bug Fixes * Default to cluster version for EKS and self managed node groups when a `cluster_version` is not specified ([#1963](#1963)) ([fd3a3e9](fd3a3e9))
|
This PR is included in version 18.14.1 🎉 |
aidanmelen
reviewed
Mar 24, 2022
| @@ -27,6 +27,11 @@ output "cluster_oidc_issuer_url" { | |||
| value = try(aws_eks_cluster.this[0].identity[0].oidc[0].issuer, "") | |||
| } | |||
|
|
|||
| output "cluster_version" { | |||
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
…when a `cluster_version` is not specified (terraform-aws-modules#1963)
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
### [18.14.1](terraform-aws-modules/terraform-aws-eks@v18.14.0...v18.14.1) (2022-03-24) ### Bug Fixes * Default to cluster version for EKS and self managed node groups when a `cluster_version` is not specified ([terraform-aws-modules#1963](terraform-aws-modules#1963)) ([fd3a3e9](terraform-aws-modules@fd3a3e9))
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
…when a `cluster_version` is not specified (terraform-aws-modules#1963)
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
### [18.14.1](terraform-aws-modules/terraform-aws-eks@v18.14.0...v18.14.1) (2022-03-24) ### Bug Fixes * Default to cluster version for EKS and self managed node groups when a `cluster_version` is not specified ([terraform-aws-modules#1963](terraform-aws-modules#1963)) ([fd3a3e9](terraform-aws-modules@fd3a3e9))
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.14.1](terraform-aws-modules/terraform-aws-eks@v18.14.0...v18.14.1) (2022-03-24) ### Bug Fixes * Default to cluster version for EKS and self managed node groups when a `cluster_version` is not specified ([#1963](terraform-aws-modules/terraform-aws-eks#1963)) ([fac563c](terraform-aws-modules/terraform-aws-eks@fac563c))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cluster_versionis not specifiedcluster_versionoutput for users to use when using separate node group sub-modules (see updatedcompleteexample)Motivation and Context
cluster_version = null#1959versionon the EKS cluster resource is optional and will default to the latest Kubernetes version supported by EKS. However, if a version is not specified in the root module viavar.cluster_version, then a version is not propagated to the sub-modules which can result in an error. By changing from thevar.cluster_versionto the EKS cluster resource output ofversionand using that as the default, we are able to achieve the same functionality when users do not specify avar.cluster_versionBreaking Changes
How Has This Been Tested?
examples/*projectscompleteexample and verified functionality