Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump kms module to 1.0.2 to fix malformed policy document when not specifying key_owners #2163

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

pfragoso
Copy link
Contributor

Description

when enabling the default policy without key_owners it will lead to a malformed document

│ Error: error creating KMS Key: MalformedPolicyDocumentException: Policy contains a statement with no principal.

Motivation and Context

Downstream the fix from terraform-aws-modules/terraform-aws-kms#2

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@pfragoso pfragoso changed the title bump kms module to 1.0.2 to fix malformed policy document when not specifying key_owners fix: bump kms module to 1.0.2 to fix malformed policy document when not specifying key_owners Jul 20, 2022
@pfragoso pfragoso changed the title fix: bump kms module to 1.0.2 to fix malformed policy document when not specifying key_owners fix: Bump kms module to 1.0.2 to fix malformed policy document when not specifying key_owners Jul 20, 2022
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pfragoso !

@bryantbiggs bryantbiggs merged commit 0fd1ab1 into terraform-aws-modules:master Jul 20, 2022
antonbabenko pushed a commit that referenced this pull request Jul 20, 2022
### [18.26.5](v18.26.4...v18.26.5) (2022-07-20)

### Bug Fixes

* Bump kms module to 1.0.2 to fix malformed policy document when not specifying key_owners ([#2163](#2163)) ([0fd1ab1](0fd1ab1))
@antonbabenko
Copy link
Member

This PR is included in version 18.26.5 🎉

@pfragoso pfragoso deleted the fix/key-owners branch July 20, 2022 18:31
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jul 22, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jul 22, 2022
### [18.26.5](terraform-aws-modules/terraform-aws-eks@v18.26.4...v18.26.5) (2022-07-20)

### Bug Fixes

* Bump kms module to 1.0.2 to fix malformed policy document when not specifying key_owners ([terraform-aws-modules#2163](terraform-aws-modules#2163)) ([0fd1ab1](terraform-aws-modules@0fd1ab1))
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
### [18.26.5](terraform-aws-modules/terraform-aws-eks@v18.26.4...v18.26.5) (2022-07-20)

### Bug Fixes

* Bump kms module to 1.0.2 to fix malformed policy document when not specifying key_owners ([#2163](terraform-aws-modules/terraform-aws-eks#2163)) ([de8d3b6](terraform-aws-modules/terraform-aws-eks@de8d3b6))
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants