Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove empty "" from node group names output when node group creation is disabled #2197

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Remove empty "" from node group names output when node group creation is disabled

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bryantbiggs bryantbiggs merged commit d2f162b into terraform-aws-modules:master Aug 9, 2022
@bryantbiggs bryantbiggs deleted the fix/empty-asg-names branch August 9, 2022 19:25
antonbabenko pushed a commit that referenced this pull request Aug 9, 2022
### [18.27.1](v18.27.0...v18.27.1) (2022-08-09)

### Bug Fixes

* Remove empty `""` from node group names output when node group creation is disabled ([#2197](#2197)) ([d2f162b](d2f162b))
@antonbabenko
Copy link
Member

This PR is included in version 18.27.1 🎉

baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
### [18.27.1](terraform-aws-modules/terraform-aws-eks@v18.27.0...v18.27.1) (2022-08-09)

### Bug Fixes

* Remove empty `""` from node group names output when node group creation is disabled ([#2197](terraform-aws-modules/terraform-aws-eks#2197)) ([3495c0d](terraform-aws-modules/terraform-aws-eks@3495c0d))
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty value on self_managed_node_groups_autoscaling_group_names when default node group not created
2 participants