fix: Include all certificate fingerprints in the OIDC provider thumbprint list #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
changed the title
bryantbiggs
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Nov 22, 2022
### [18.31.1](v18.31.0...v18.31.1) (2022-11-22) ### Bug Fixes * Include all certificate fingerprints in the OIDC provider thumbprint list ([#2307](#2307)) ([7436178](7436178))
|
This PR is included in version 18.31.1 🎉 |
|
Thanks for getting this in so quickly! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include all certificate fingerprints in the thumbprint list, rather than just the first one
Motivation and Context
I'm following the Terraform documentation for enabling IRSA https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_cluster#enabling-iam-roles-for-service-accounts. This suggests that all the certificates thumbprints should be listed. This module currently only selects the first one, which should be the highest root certificate in the chain pulled back by the
tls_certificatedata lookup. I can't see anything to suggest that this is intentional.Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI only have access to my work environment. I have tested this change against our development and staging environments without issues.