We should ignore changes to node ASG desired_capacity

[max-rocket-internet]

I have issues

I'm submitting a

• feature request

The reason is that after cluster creation, almost everyone will run the k8s node autoscaler. This autoscaler is changing the desired_capacity to suit resources required by the cluster. So when the cluster autoscales, then TF is run again later, you see something like this:

  ~ module.cluster_1.aws_autoscaling_group.workers
      desired_capacity:   "5" => "3"

You can just add a lifecycle statement to resource aws_autoscaling_group.workers:

  lifecycle {
    ignore_changes = [ "desired_capacity" ]
  }

[brandonjbjelland]

Heh you're on the same wavelength as @ozbillwang . He submitted this exact change 16 hours ago here: https://github.com/terraform-aws-modules/terraform-aws-eks/pull/36/files

I'll close this now and plan to release over the next day or so. Closing this up.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.