-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to change asg_desired_capacity
value
#510
Comments
You made a point in this link, kindly clarify what do you mean by it (like what cluster autoscaler does here and what are its trigger event). thank you. |
The cluster-autoscaler controls all scaling up and down of the cluster. It add nodes when there's It is the normal way of scaling a cluster as it takes care of draining and moving pods in this process. It is aware of complexities like instance sizes, pod disruption budgets and more. It's this awareness that makes it really the only way to safely scale down a cluster automatically. And that's why You can manually and safely scale up the cluster yourself. But scaling down is more complicated 🙂 |
@max-rocket-internet thank you for clarification. It would be good if these details are added in the documentation if guys from your side are busy do let me know I will create a PR for it. |
@max-rocket-internet although 1 issue still exists which is that if a person changes the value of the I think it is a bug that should be resolved. |
Please do 😃 Maybe add something to https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/autoscaling.md
Maybe but it's very edge case. I don't know how we could resolve this while still ignoring changes to For your reference, I just set these to |
yes, you are right but these things need to be mentioned in the documentation because it will cause problems for people who update the My Suggestions:
|
|
@max-rocket-internet i have created a PR for it kindly have a look at it |
the issue has been resolved in #517, closing it. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I have issues
Hello everyone,
I deployed an eks cluster using this module but the issue is that I was not able to change the value of desired capacity(it default value is
1
i think so).So what I did was that I increased the
asg_min_size
value from1
to2
but the issue it generated was that it increased thedesired_capacity
value from1
to2
. Although I changed the value ofasg_min_size
from2
to1
still its value remained the same.Although I know it is
asg_desired_capacity
has been added in the ignore loopback state, to make sure its value is ignored.I just want to know is there a workaround for it. I think the point of ignoring its value
must be
mentioned in the document so that everyone knows about it easily.I'm submitting a...
NONE
What is the current behaviour?
I am unable to change the
asg_desired_capacity
value.If this is a bug, how to reproduce? Please include a code sample if relevant.
Not sure, i think it is a bug that increasing the value of
asg_min_size
changes the value ofasg_max_capacity
, correct me if I am wrong.What's the expected behaviour?
I should be able to change the
asg_desired_capacity
value.Are you able to fix this problem and submit a PR? Link here if you have already.
I can update the document
Environment details
Any other relevant info
The text was updated successfully, but these errors were encountered: