-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🔒 IMDSv2 metadata restrictions #938
Conversation
@barryib @brandonjbjelland @bryantbiggs @antonbabenko It wasnt apparent in the contributing guidelines who would review this, but I'm wondering if someone could take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
Downside: it causes an update to Launch Templates even though it's setting default values. Silly Terraform. Avoiding that would create some really messy code. We'll just have to add a note to the changelog and take the abuse 😄
…s-modules#938) NOTES: Addition of the IMDSv2 metadata configuration block to Launch Templates will cause a diff to be generated for existing Launch Templates on first Terraform apply. The defaults match existing behaviour.
terraform-aws-modules#938 NOTES: Addition of the IMDSv2 metadata configuration block to Launch Templates will cause a diff to be generated for existing Launch Templates on first Terraform apply. The defaults match existing behaviour.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Metadata Options for Launch Template
Description
Adding metadata options to the launch template options, which will allow for IDMS v2 restrictions: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html
Checklist