Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🔒 IMDSv2 metadata restrictions #938

Merged
merged 2 commits into from
Jul 12, 2020
Merged

feat: 🔒 IMDSv2 metadata restrictions #938

merged 2 commits into from
Jul 12, 2020

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Jun 30, 2020

Metadata Options for Launch Template

Description

Adding metadata options to the launch template options, which will allow for IDMS v2 restrictions: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html

Checklist

@danquack danquack changed the title 🔒 IDMSv2 metadata restrictions feat 🔒 IDMSv2 metadata restrictions Jun 30, 2020
@danquack danquack changed the title feat 🔒 IDMSv2 metadata restrictions feat: 🔒 IDMSv2 metadata restrictions Jun 30, 2020
@danquack
Copy link
Contributor Author

danquack commented Jun 30, 2020

@barryib @brandonjbjelland @bryantbiggs @antonbabenko It wasnt apparent in the contributing guidelines who would review this, but I'm wondering if someone could take a look

Copy link
Contributor

@dpiddockcmp dpiddockcmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

Downside: it causes an update to Launch Templates even though it's setting default values. Silly Terraform. Avoiding that would create some really messy code. We'll just have to add a note to the changelog and take the abuse 😄

@dpiddockcmp dpiddockcmp merged commit 23ad497 into terraform-aws-modules:master Jul 12, 2020
@dpiddockcmp dpiddockcmp changed the title feat: 🔒 IDMSv2 metadata restrictions feat: 🔒 IMDSv2 metadata restrictions Jul 12, 2020
barryib pushed a commit to Polyconseil/terraform-aws-eks that referenced this pull request Oct 25, 2020
…s-modules#938)

NOTES: Addition of the IMDSv2 metadata configuration block to Launch Templates will cause a diff to be generated for existing Launch Templates on first Terraform apply. The defaults match existing behaviour.
bartmanus added a commit to celtra/terraform-aws-eks that referenced this pull request Jun 28, 2022
terraform-aws-modules#938
NOTES: Addition of the IMDSv2 metadata configuration block to Launch Templates will cause a diff to be generated for existing Launch Templates on first Terraform apply. The defaults match existing behaviour.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants