feat: Add load_balancers parameter to associate a CLB (Classic Load Balancer) to worker groups ASG

[hacker65536]

PR o'clock

Description

Add load_balancers for clb be associated to asg.

Resolves #1036

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[dpiddockcmp]

Please can you duplicate this change in the ASG in workers_launch_template.tf, thank you.

[barryib]

@hacker65536 Thanks for your contribution.

I was just wondering what is your actual use case. What you're trying to achieve by adding a load balancer to all your worker nodes in a kubernetes cluster. Is the kubernetes model does't fit here (using k8s service or ingress) ?

[hacker65536]

I'm trying to using clb + envoy to handle grpc app.

[jgournet]

Shouldn't this line be:

var.worker_groups_launch_template[count.index],

?

[oraclef2k20]

Thank you

[barryib]

Thanks @hacker65536 for your contribution.

[mumoshu]

Is the kubernetes model does't fit here (using k8s service or ingress) ?

Using K8s service LBs makes it harder to recreate the cluster, because you need to use e.g. Route 53 to switch traffic from the old to the new cluster. So I'd use service LBs and (current) AWS ingresses only for dev clusters that can be deleted without care. So this feature should generally be useful for any production setup. Just my two cents 😃

[barryib]

Is the kubernetes model does't fit here (using k8s service or ingress) ?

Using K8s service LBs makes it harder to recreate the cluster, because you need to use e.g. Route 53 to switch traffic from the old to the new cluster. So I'd use service LBs and (current) AWS ingresses only for dev clusters that can be deleted without care. So this feature should generally be useful for any production setup. Just my two cents 😃

Great. Thanks @mumoshu for the clarification.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.