Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in slack emoji support #11

Merged
merged 7 commits into from
Jun 6, 2018

Conversation

sprutner
Copy link
Contributor

@sprutner sprutner commented Jun 5, 2018

I added in some slack emoji support instead of using the default webhook icon.

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Please update formatting.

@sprutner
Copy link
Contributor Author

sprutner commented Jun 5, 2018

@antonbabenko Great! What can I update with regards to formatting?

@antonbabenko antonbabenko merged commit 16ec202 into terraform-aws-modules:master Jun 6, 2018
@antonbabenko
Copy link
Member

Merged, fixed formatting in 969628e and released v1.5.0.

Thank you for your contribution.

@sprutner sprutner deleted the patch1 branch June 18, 2018 20:12
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants