Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding allowed_cidr var #28

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Adding allowed_cidr var #28

merged 2 commits into from
Jun 8, 2017

Conversation

tfhartmann
Copy link
Member

This should allow us to pass CIDR blocks to the Security Group, which
lets us use this module for internal bastion hosts, or bastion hosts
that shouldn't be open to the world.

If this gets accepted, could we also tag a new release?

Thanks!

@tfhartmann
Adding allowed_cidr var
009ee82 
This should allow us to pass CIDR blocks to the Security Group, which
lets us use this module for internal bastion hosts, or bastion hosts
that shouldn't be open to the world.
@antonbabenko
Copy link
Member

Looks good to me. Could you also split aws_security_group into aws_security_group and aws_security_group_rule and add aws_security_group_rule.id to outputs, or we can do it in another PR (you decide) ?

@tfhartmann
Copy link
Member Author

HA! I was totally think about that too! I'll do a quick update!

@antonbabenko antonbabenko merged commit 83266b9 into terraform-community-modules:master Jun 8, 2017
@antonbabenko
Copy link
Member

New release is v1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfhartmann @antonbabenko