Add the ability to allow access based on security group ID #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow us to pass CIDR blocks to the Security Group, which lets us use this module for internal bastion hosts, or bastion hosts that shouldn't be open to the world.
antonbabenko
reviewed
Jun 9, 2017
README.md
Outdated
| @@ -27,6 +27,7 @@ Only SSH access is allowed to the bastion host. | |||
| * `eip` - EIP to put into EC2 tag (can be used with scripts like https://github.com/skymill/aws-ec2-assign-elastic-ip, default - empty value) | |||
| * `key_name` - Launch configuration key name to be applied to created instance(s). | |||
| * `allowed_cidr` - A list of CIDR Networks to allow ssh access to. Defaults to 0.0.0.0/0 | |||
| * `allowed_security_groups` - A list of Security Group ID's to allow access to. Defaults to empty list | |||
There was a problem hiding this comment.
It can be more descriptive if you say "A list of Security Group ID's to allow access to the bastion host (useful if bastion is deployed internally)".
|
done and done |
|
Cool. Update CHANGELOG as well, please. LGTM, you can now merge and tag it yourself :) |
|
Sweet, I am now drunk with power! 🔋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for internal bastion, so for example when you only want this host to be open to a particular SG rather then a CIDR range
Sorry about opening a second PR, I would have added to the previous one, but wasn't fast enough :p