Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields for additional users should have defaults #630

Open
jyoungs opened this issue Aug 13, 2024 · 1 comment
Open

Fields for additional users should have defaults #630

jyoungs opened this issue Aug 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jyoungs
Copy link

jyoungs commented Aug 13, 2024

TL;DR

https://github.com/terraform-google-modules/terraform-google-sql-db/blob/v21.0.0/modules/postgresql/variables.tf#L335C5-L335C13

Password is intended to be optional with the conditional (already setup) validating that password is required IFF random_password == false

IMO random_password should default to true, but that's more of an opinion.

Terraform Resources

No response

Detailed design

type = list(object({
    name            = string
    password        = optional(string, "")
    random_password = optional(bool, true)
  }))


### Additional information

_No response_
@jyoungs jyoungs added the enhancement New feature or request label Aug 13, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants