Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kms_alias: Retry lookups after creation #1040

Merged
merged 1 commit into from
Jul 8, 2017
Merged

Conversation

radeksimko
Copy link
Member

This is to address the following test failures:

=== RUN   TestAccAWSKmsAlias_basic
--- FAIL: TestAccAWSKmsAlias_basic (24.32s)
    testing.go:280: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        CREATE: aws_kms_alias.nothing
          arn:           "" => "<computed>"
          target_key_id: "" => "950636dd-a68b-4db1-a623-5872e0a9bfeb"

=== RUN   TestAccAWSKmsAlias_importBasic
--- FAIL: TestAccAWSKmsAlias_importBasic (25.50s)
    testing.go:428: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        CREATE: aws_kms_alias.name_prefix
          arn:           "" => "<computed>"
          name_prefix:   "" => "alias/tf-acc-key-alias-9109626292984107802" (forces new resource)
          target_key_id: "" => "cc70e683-f4b6-4ca3-a6ce-b53d4805f89b"

=== RUN   TestAccAWSKmsAlias_no_name
--- FAIL: TestAccAWSKmsAlias_no_name (24.82s)
    testing.go:428: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        CREATE: aws_kms_alias.name_prefix
          arn:           "" => "<computed>"
          name_prefix:   "" => "alias/tf-acc-key-alias-6845962144816329722" (forces new resource)
          target_key_id: "" => "8efc5d46-4c09-4409-9288-e953c6e386fa"

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jul 3, 2017
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radeksimko radeksimko merged commit e881a60 into master Jul 8, 2017
@radeksimko radeksimko deleted the b-kms-alias-retry-read branch July 8, 2017 11:42
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants