Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_route53_health_check: add support for health_check regions #1116

Merged
merged 1 commit into from
Jul 11, 2017
Merged

resource/aws_route53_health_check: add support for health_check regions #1116

merged 1 commit into from
Jul 11, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 11, 2017

Fixes: #784

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53HealthCheck_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRoute53HealthCheck_ -timeout 120m
=== RUN   TestAccAWSRoute53HealthCheck_importBasic
--- PASS: TestAccAWSRoute53HealthCheck_importBasic (29.04s)
=== RUN   TestAccAWSRoute53HealthCheck_basic
--- PASS: TestAccAWSRoute53HealthCheck_basic (50.80s)
=== RUN   TestAccAWSRoute53HealthCheck_withSearchString
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (45.29s)
=== RUN   TestAccAWSRoute53HealthCheck_withChildHealthChecks
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (40.46s)
=== RUN   TestAccAWSRoute53HealthCheck_withHealthCheckRegions
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (25.17s)
=== RUN   TestAccAWSRoute53HealthCheck_IpConfig
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (24.83s)
=== RUN   TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (28.50s)
=== RUN   TestAccAWSRoute53HealthCheck_withSNI
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (63.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	307.522s

@stack72
resource/aws_route53_health_check: add support for health_check regions
48bf318 
Fixes: #784

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53HealthCheck_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRoute53HealthCheck_ -timeout 120m
=== RUN   TestAccAWSRoute53HealthCheck_importBasic
--- PASS: TestAccAWSRoute53HealthCheck_importBasic (29.04s)
=== RUN   TestAccAWSRoute53HealthCheck_basic
--- PASS: TestAccAWSRoute53HealthCheck_basic (50.80s)
=== RUN   TestAccAWSRoute53HealthCheck_withSearchString
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (45.29s)
=== RUN   TestAccAWSRoute53HealthCheck_withChildHealthChecks
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (40.46s)
=== RUN   TestAccAWSRoute53HealthCheck_withHealthCheckRegions
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (25.17s)
=== RUN   TestAccAWSRoute53HealthCheck_IpConfig
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (24.83s)
=== RUN   TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (28.50s)
=== RUN   TestAccAWSRoute53HealthCheck_withSNI
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (63.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	307.522s
```
@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 11, 2017
radeksimko
radeksimko approved these changes Jul 11, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stack72 stack72 merged commit 8f23ff8 into master Jul 11, 2017
@stack72 stack72 deleted the f-aws-health-check-regions-784 branch July 11, 2017 13:59
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: allow specification of health checker regions in aws_route53_health_check
2 participants
@stack72 @radeksimko