resource/aws_ssm_parameter: Refresh from state on 404 #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: hashicorp#1007 when an SSM Parameter is manually deleted, Terraform should recreate it. For some reason, Terraform was inspecting the `InvalidParameters` part of the response rather than actually checking that the Parameter was returned. By removing this and then refreshing from state on no parameters found, a manually deleted parameter can then be recreated As part of this PR, a lot of the acceptance tests were restructured. Previously, each acceptance tests was making multiple API requests to check type and value of the param. This is replaced by 1 API request now to check the Parameter now exists. We can then check the type and value from our statefile ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMParameter_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMParameter_ -timeout 120m === RUN TestAccAWSSSMParameter_basic --- PASS: TestAccAWSSSMParameter_basic (23.73s) === RUN TestAccAWSSSMParameter_disappears --- PASS: TestAccAWSSSMParameter_disappears (17.86s) === RUN TestAccAWSSSMParameter_update --- PASS: TestAccAWSSSMParameter_update (46.65s) === RUN TestAccAWSSSMParameter_changeNameForcesNew --- PASS: TestAccAWSSSMParameter_changeNameForcesNew (42.80s) === RUN TestAccAWSSSMParameter_secure --- PASS: TestAccAWSSSMParameter_secure (24.52s) === RUN TestAccAWSSSMParameter_secure_with_key --- PASS: TestAccAWSSSMParameter_secure_with_key (65.95s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 221.529s ```
Ninir
added
the
enhancement
nbaztec
pushed a commit
to nbaztec/terraform-provider-aws
that referenced
this pull request
Sep 26, 2017
…hstate-on-404-1007 resource/aws_ssm_parameter: Refresh from state on 404
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1007
when an SSM Parameter is manually deleted, Terraform should recreate it.
For some reason, Terraform was inspecting the
InvalidParameterspartof the response rather than actually checking that the Parameter was
returned. By removing this and then refreshing from state on no
parameters found, a manually deleted parameter can then be recreated
As part of this PR, a lot of the acceptance tests were restructured.
Previously, each acceptance tests was making multiple API requests to
check type and value of the param. This is replaced by 1 API request now
to check the Parameter now exists. We can then check the type and value
from our statefile