Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/fsx_lustre_file_system - add support for backup retention #14446

Merged
merged 4 commits into from
Sep 18, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13527

Release note for CHANGELOG:

resource_aws_fsx_lustre_file_system - add support for backup retention

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSFsxLustreFileSystem_basic (598.55s)
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (558.08s)
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (741.28s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (583.26s)

@DrFaust92 DrFaust92 requested a review from a team August 2, 2020 20:39
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 2, 2020
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_disappears\|TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays\|TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_disappears\|TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays\|TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_disappears
=== PAUSE TestAccAWSFsxLustreFileSystem_disappears
=== RUN   TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== RUN   TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== PAUSE TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== CONT  TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== CONT  TestAccAWSFsxLustreFileSystem_disappears
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (514.34s)
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (523.47s)
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (543.13s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (579.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	579.684s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_disappears\|TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays\|TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_disappears\|TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays\|TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_disappears
=== PAUSE TestAccAWSFsxLustreFileSystem_disappears
=== RUN   TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== RUN   TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== PAUSE TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== CONT  TestAccAWSFsxLustreFileSystem_disappears
=== CONT  TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (417.26s)
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (467.84s)
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (502.68s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (517.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	520.946s

@breathingdust breathingdust added this to the v3.8.0 milestone Sep 18, 2020
@breathingdust breathingdust merged commit 5dd5ded into hashicorp:master Sep 18, 2020
breathingdust added a commit that referenced this pull request Sep 18, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 22, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2020
@DrFaust92 DrFaust92 deleted the r/fsx_lustre_fs_renetion branch April 15, 2021 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants