r/db_parameter_group: Allow underscores in names

[kirillshevch]

No description provided.

[Ninir]

Hey @kirillshevch

Thanks for this. Just checked in the console, looks good to me :)
For the record, how did you get into this issue and fix?

[kirillshevch]

@Ninir reproduced with Terraform v0.10.2

1. My current state of AWS was exported by terraforming
2. I got rds.tf

resource "aws_db_instance" "cryptostatus" {
    identifier                = "cryptostatus"
    allocated_storage         = 20
    storage_type              = "gp2"
    engine                    = "postgres"
    engine_version            = "9.6.1"
    instance_class            = "db.t2.large"
    name                      = "cryptostatus_production"
    username                  = "deployer"
    password                  = "xxxxxxxx"
    port                      = 5432
    publicly_accessible       = false
    availability_zone         = "us-west-2a"
    security_group_names      = []
    vpc_security_group_ids    = ["sg-98f2e1e1"]
    db_subnet_group_name      = "default"
    parameter_group_name      = "default.postgres9.6"
    multi_az                  = false
    backup_retention_period   = 7
    backup_window             = "09:40-10:10"
    maintenance_window        = "sat:07:59-sat:08:29"
    final_snapshot_identifier = "cryptostatus-final"
}
resource "aws_db_instance" "translations" {
    identifier                = "translations"
    allocated_storage         = 5
    storage_type              = "gp2"
    engine                    = "postgres"
    engine_version            = "9.6.1"
    instance_class            = "db.t2.micro"
    name                      = "cryptostatus_translations_production"
    username                  = "deployer"
    password                  = "xxxxxxxx"
    port                      = 5432
    publicly_accessible       = true
    availability_zone         = "us-west-2a"
    security_group_names      = []
    vpc_security_group_ids    = ["sg-98f2e1e1"]
    db_subnet_group_name      = "default"
    parameter_group_name      = "default.postgres9.6"
    multi_az                  = true
    backup_retention_period   = 7
    backup_window             = "06:10-06:40"
    maintenance_window        = "sat:12:21-sat:12:51"
    final_snapshot_identifier = "translations-final"
}

3. terraform plan

2 error(s) occurred:

* aws_db_parameter_group.default-postgres9-5: only lowercase alphanumeric characters and hyphens allowed in "name"
* aws_db_parameter_group.default-postgres9-6: only lowercase alphanumeric characters and hyphens allowed in "name"

[Ninir]

Perfect thank you :)

Thanks for the work here!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!