Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased ClientVpnAuthorizationRule timeouts from 5 to 10 minutes #15367

Merged
merged 1 commit into from
Oct 1, 2020
Merged

increased ClientVpnAuthorizationRule timeouts from 5 to 10 minutes #15367

merged 1 commit into from
Oct 1, 2020

Conversation

philnichol
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15349

Release note for CHANGELOG:

resource/aws_ec2_client_vpn_authorization_rule: Update timeout from 5min to 10min

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2ClientVpnAuthorizationRules_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2ClientVpnAuthorizationRules_ -timeout 120m
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.836s [no tests to run]

@philnichol philnichol requested a review from a team September 26, 2020 07:47
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 26, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 26, 2020
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 1, 2020
@bflad bflad added this to the v3.9.0 milestone Oct 1, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, @philnichol 🚀

@bflad bflad merged commit 7bcc260 into hashicorp:master Oct 1, 2020
bflad added a commit that referenced this pull request Oct 1, 2020
@philnichol philnichol deleted the b-client_vpn_auth_rule_timeout_increase branch October 2, 2020 09:04
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further increase ClientVpnAuthorizationRuleRevokedTimeout
2 participants