terraform miss the Use Origin Cache Headers

[hashibot]

This issue was originally opened by @arbabnazar as hashicorp/terraform#16209. It was migrated here as a result of the provider split. The original body of the issue is below.

---

I want to use AWS cloudfront cache behaviour to Use Origin Cache Headers as sent by my server.

However in terraform, the min_ttl, max_ttl and default_ttl is required.

Is there a way to to use the Use Origin Cache Headers in terraform?

[xavimota]

I'm facing the same problem.
I need to create a cloudfront with terraform with "Use Origin Cache Headers" from my S3 bucket.
But it's not possible to configure it in terraform so a manual operation is needed.

[allanalvaro]

Hello, I've got the same problem. Any news about that?

[wintergren]

Same here, what's the status on this?

@radeksimko @bflad or anyone else working with the provider..

[bflad]

While the attributes are marked as required in Terraform, taking a look at the SDK documentation implies that CloudFront might "do the right thing" here if the appropriate headers are set in the origin.

Specifically this sentence for Default TTL and Max TTL:

The value that you specify applies only when your origin does not add HTTP headers such as Cache-Control max-age, Cache-Control s-maxage, and Expires to objects.

    // The default amount of time that you want objects to stay in CloudFront caches
    // before CloudFront forwards another request to your origin to determine whether
    // the object has been updated. The value that you specify applies only when
    // your origin does not add HTTP headers such as Cache-Control max-age, Cache-Control
    // s-maxage, and Expires to objects. For more information, see Specifying How
    // Long Objects and Errors Stay in a CloudFront Edge Cache (Expiration) (http://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html)
    // in the Amazon CloudFront Developer Guide.
    DefaultTTL *int64 `type:"long"`

   // The maximum amount of time that you want objects to stay in CloudFront caches
    // before CloudFront forwards another request to your origin to determine whether
    // the object has been updated. The value that you specify applies only when
    // your origin adds HTTP headers such as Cache-Control max-age, Cache-Control
    // s-maxage, and Expires to objects. For more information, see Specifying How
    // Long Objects and Errors Stay in a CloudFront Edge Cache (Expiration) (http://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html)
    // in the Amazon CloudFront Developer Guide.
    MaxTTL *int64 `type:"long"`

    // The minimum amount of time that you want objects to stay in CloudFront caches
    // before CloudFront forwards another request to your origin to determine whether
    // the object has been updated. For more information, see Specifying How Long
    // Objects and Errors Stay in a CloudFront Edge Cache (Expiration) (http://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html)
    // in the Amazon Amazon CloudFront Developer Guide.
    //
    // You must specify 0 for MinTTL if you configure CloudFront to forward all
    // headers to your origin (under Headers, if you specify 1 for Quantity and
    // * for Name).
    //
    // MinTTL is a required field
    MinTTL *int64 `type:"long" required:"true"`

Luckily, it also looks like the cacheBehaviorHash function is optionally including the default_ttl and max_ttl attributes, so this seems like it wouldn't require Terraform state migrations to change those attributes due to changing set hash values. Depending on the API response back (missing vs it returning some default values) would determine if we would want Computed: true vs Default: # on the attributes to prevent perpetual diffs.

[bflad]

TL;DR is seems like we might be able to set Optional: true and Computed: true/Default: # on the default_ttl and max_ttl attributes. I'll submit a PR and run our acceptance testing against it.

For cross-reference this is the same request as #1472.

[bflad]

Upon further testing when the attributes are not supplied during creation, AWS will set the default default_ttl to 1 day and max_ttl to 365 days. A pull request to make these attributes optional (along with min_ttl) can be found here: #3571

[bflad]

Support to make all 3 TTL arguments optional has been merged into master and will be released in v1.11.0 of the AWS provider, likely at the end of the week. Please note they are default_ttl (1 day), max_ttl (365 days), and min_ttl (0 days) to match the behavior of the API and console.

[bflad]

This has been released in version 1.11.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[arbabnazar]

@bflad and team, thank you very much for adding this feature.

[digitalkaoz]

@bflad i dont get it completely...

they are optional now, but then the aws defaults apply? how do i set Use Origin Cache Headers then?

[matt-zangen]

@digitalkaoz if you remove all three caching properties from your config and apply, the default values will be set in these properties, but CloudFront will be configured with Use Origin Cache Headers.

[angristan]

Thanks @matt-zangen! I can confirm that removing min_ttl, default_ttl and max_ttl enables Use Origin Cache Headers on the behavior.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!