resource/aws_elasticsearch_domain: Added ForceNew to vpc_options

[Ninir]

This fixes an issue where you could not switch from an internet-based ES endpoint to a VPC_based one, and vice-versa. Documentation about those limitations

Before

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticSearchDomain_internetToVpcEndpoint'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticSearchDomain_internetToVpcEndpoint -timeout 120m
=== RUN   TestAccAWSElasticSearchDomain_internetToVpcEndpoint
--- FAIL: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (737.45s)
	testing.go:492: Step 1 error: Error applying: 1 error(s) occurred:
		
		* aws_elasticsearch_domain.example: 1 error(s) occurred:
		
		* aws_elasticsearch_domain.example: ValidationException: Domain should be created with VPC options to update VPC options later
			status code: 400, request id: 92ffeaf5-bfc4-11e7-881d-b1dcd6c02d98
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	737.489s
make: *** [testacc] Error 1

After:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticSearchDomain_internetToVpcEndpoint'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticSearchDomain_internetToVpcEndpoint -timeout 120m
=== RUN   TestAccAWSElasticSearchDomain_internetToVpcEndpoint
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2083.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2083.229s

[stack72]

@Ninir do you think a link to these limitations should be added to the documentation as well as this change?

[Ninir]

@stack72 Hey Paul,

This is an excellent idea, added in! Good call! 😄 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!