resource/ssm_resource_data_sync: Support import #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atsushi-ishibashi
commented
Feb 1, 2018
atsushi-ishibashi
commented
bflad
added
enhancement
Ninir
reviewed
Feb 1, 2018
| @@ -15,6 +15,13 @@ func resourceAwsSsmResourceDataSync() *schema.Resource { | |||
| Read: resourceAwsSsmResourceDataSyncRead, | |||
| Delete: resourceAwsSsmResourceDataSyncDelete, | |||
|
|
|||
| Importer: &schema.ResourceImporter{ | |||
| State: func(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) { | |||
| d.Set("name", d.Id()) | |||
There was a problem hiding this comment.
Why not reading the name line 103? as in: d.Set("name", syncItem.SyncName)
There was a problem hiding this comment.
You're right! Thank you!
TF_ACC=1 go test ./aws -v -run=TestAccAWSSsmResourceDataSync_import -timeout 120m
=== RUN TestAccAWSSsmResourceDataSync_import
--- PASS: TestAccAWSSsmResourceDataSync_import (68.67s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 68.710s
Ninir
added
the
waiting-response
Ninir
approved these changes
Feb 2, 2018
There was a problem hiding this comment.
This is looking very good, thanks for taking the time to do it! 🚀 👍
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSsmResourceDataSync_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSsmResourceDataSync_ -timeout 120m
=== RUN TestAccAWSSsmResourceDataSync_basic
--- PASS: TestAccAWSSsmResourceDataSync_basic (58.74s)
=== RUN TestAccAWSSsmResourceDataSync_import
--- PASS: TestAccAWSSsmResourceDataSync_import (62.62s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 121.427s
|
This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
removed
the
waiting-response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.