Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally filter server certificates by path prefix. #3801

Merged
merged 3 commits into from
Apr 13, 2018
Merged

Optionally filter server certificates by path prefix. #3801

merged 3 commits into from
Apr 13, 2018

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Mar 16, 2018

Not sure how to test this, but the code is pretty straightforward.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 16, 2018
@jmcarp
Copy link
Contributor Author

jmcarp commented Mar 25, 2018

@bflad: does this look reasonable? I'll fix up merge conflicts if so.

@bflad
Copy link
Contributor

bflad commented Mar 26, 2018

Considering its built into the API 👍 I would just also expect a quick acceptance test as well.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. waiting-response Maintainers are waiting on response from community or contributor. labels Mar 26, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 26, 2018
@jmcarp
Copy link
Contributor Author

jmcarp commented Mar 26, 2018

Updated with a test:

± TF_ACC=1 go test -v github.com/terraform-providers/terraform-provider-aws/aws -run=TestAccAWSDataSourceIAMServerCertificate_
=== RUN   TestAccAWSDataSourceIAMServerCertificate_basic
--- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (13.31s)
=== RUN   TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix
--- PASS: TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix (2.00s)
=== RUN   TestAccAWSDataSourceIAMServerCertificate_path
--- PASS: TestAccAWSDataSourceIAMServerCertificate_path (11.60s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       26.967s

@jmcarp
Copy link
Contributor Author

jmcarp commented Mar 27, 2018

Ready for review @bflad

@jmcarp
Copy link
Contributor Author

jmcarp commented Apr 5, 2018

Ping @bflad. Let me know if this needs more work on my end.

@jmcarp
Copy link
Contributor Author

jmcarp commented Apr 11, 2018

Bump @bflad @radeksimko 😄

@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 13, 2018
@bflad bflad added this to the v1.15.0 milestone Apr 13, 2018
bflad
bflad approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmcarp! LGTM 🚀

3 tests passed (all tests)
=== RUN   TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix
--- PASS: TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix (1.96s)
=== RUN   TestAccAWSDataSourceIAMServerCertificate_basic
--- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (11.45s)
=== RUN   TestAccAWSDataSourceIAMServerCertificate_path
--- PASS: TestAccAWSDataSourceIAMServerCertificate_path (11.64s)

@bflad bflad merged commit 74a075e into hashicorp:master Apr 13, 2018
bflad added a commit that referenced this pull request Apr 13, 2018
@bflad
Update CHANGELOG for #3801
4b88baf
@bflad
Copy link
Contributor

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad mentioned this pull request May 3, 2018
Closed
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarp @bflad