Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_batch_compute_environment: Correctly set compute_resources in state #3824

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 17, 2018

Found via TF_SCHEMA_PANIC_ON_ERROR=1 testing

TestAccAWSBatchComputeEnvironment_createEc2
panic: compute_resources.0.max_vcpus: '' expected type 'int', got unconvertible type '*int64'
resource_aws_batch_compute_environment.go:270

TestAccAWSBatchComputeEnvironment_createEc2WithTags
panic: compute_resources.0.instance_role: '' expected type 'string', got unconvertible type '*string'
resource_aws_batch_compute_environment.go:270

TestAccAWSBatchComputeEnvironment_createSpot
panic: compute_resources.0.spot_iam_fleet_role: '' expected type 'string', got unconvertible type '*string'
resource_aws_batch_compute_environment.go:270

TestAccAWSBatchComputeEnvironment_updateMaxvCpus
panic: compute_resources.0.min_vcpus: '' expected type 'int', got unconvertible type '*int64'
resource_aws_batch_compute_environment.go:270

TestAccAWSBatchJobQueue_basic
panic: compute_resources.0.desired_vcpus: '' expected type 'int', got unconvertible type '*int64'
resource_aws_batch_compute_environment.go:270

Tests

11 tests passed (all tests)
=== RUN   TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (21.35s)
=== RUN   TestAccAWSBatchComputeEnvironment_createSpot
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (46.40s)
=== RUN   TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (73.11s)
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2WithTags
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (74.06s)
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (85.05s)
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (88.15s)
=== RUN   TestAccAWSBatchComputeEnvironment_createUnmanaged
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (89.51s)
=== RUN   TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName
--- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (92.24s)
=== RUN   TestAccAWSBatchComputeEnvironment_updateInstanceType
--- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (94.23s)
=== RUN   TestAccAWSBatchComputeEnvironment_updateState
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (112.04s)
=== RUN   TestAccAWSBatchComputeEnvironment_updateMaxvCpus
--- PASS: TestAccAWSBatchComputeEnvironment_updateMaxvCpus (118.05s)

@bflad bflad added bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service. labels Mar 17, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 17, 2018
@bflad bflad requested a review from a team March 26, 2018 13:57
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit a946f07 into master Mar 26, 2018
@bflad bflad deleted the b-aws_batch_compute_environment-schema-panic branch March 26, 2018 16:40
@bflad bflad added this to the v1.13.0 milestone Mar 26, 2018
bflad added a commit that referenced this pull request Mar 26, 2018
@bflad
Copy link
Contributor Author

bflad commented Mar 29, 2018

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants