Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lb_target_group: Prevent crash from missing matcher during read #3954

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 28, 2018

Fixes #3949

Interestingly enough, its not reproducible in us-west-2, but does crash in sa-east-1. Maybe they're testing a new service release? Sample config that panics:

provider "aws" {
  region = "sa-east-1"
}

resource "aws_lb_target_group" "example" {
  name     = "example"
  port     = 8082
  protocol = "TCP"
  vpc_id   = "${aws_vpc.example.id}"
}

resource "aws_vpc" "example" {
  cidr_block = "10.0.0.0/16"
}

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Mar 28, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Mar 28, 2018
@bflad bflad added this to the v1.13.0 milestone Mar 28, 2018
@bflad bflad requested a review from a team March 28, 2018 17:10
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 42c418f into master Mar 28, 2018
@bflad bflad deleted the b-aws_lb_target_group-prevent-matcher-crash branch March 28, 2018 17:24
bflad added a commit that referenced this pull request Mar 28, 2018
This was referenced Mar 28, 2018
@ctso
Copy link
Contributor

ctso commented Mar 28, 2018

We're also seeing this in us-east-1.

@bflad
Copy link
Contributor Author

bflad commented Mar 29, 2018

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash interacting with target groups for network load balancers
3 participants