Fixes Terraform crash for AWS Kinesis Firehose

[Puneeth-n]

fixes #4109

[bflad]

I think this can be a one line fix:

https://github.com/terraform-providers/terraform-provider-aws/blob/20adea2e019a209563352f05f498cd265d6a2789/aws/resource_aws_kinesis_firehose_delivery_stream.go#L179

[Puneeth-n]

@bflad done. I'm running acceptance tests. will update once it is done.

[bflad]

@Puneeth-n thank you very much! Sorry I meant to look into this yesterday and submit the fix. 😅

[bflad]

I'll also kick off the tests on our side just to verify this with what testing we do have.

[Puneeth-n]

@bflad here are the tests:

AWS_REGION=eu-west-1 TF_ACC=1 go test ./... -v -run=TestAccAWSKinesisFirehoseDeliveryStream_ -timeout 120m -parallel=4
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_importBasic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_importBasic (138.34s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (131.52s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource (122.38s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging (119.20s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (249.11s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic (145.06s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn (307.46s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidProcessorType
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidProcessorType (1.67s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidParameterName
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidParameterName (1.74s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates (158.22s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates (983.75s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates (159.78s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates (1133.50s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration (134.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3786.024s
root@5a926ca22be9:/go/src/github.com/terraform-providers/terraform-provider-aws#

[Puneeth-n]

@bflad No worries. :) We wanna move to NodeJs 8.10 and this was a real blocker for us so looked into it today. Thanks for the review 🚀 Any idea when 1.14.1 will be released?

[bflad]

I'm planning on releasing v1.14.1 tomorrow 😄

[bflad]

LGTM - thank you again 🚀

[bflad]

This has been released in version 1.14.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!