Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources/wafregional_web_acl: add rule type support #4307

Merged
merged 1 commit into from
Jun 25, 2018
Merged

resources/wafregional_web_acl: add rule type support #4307

merged 1 commit into from
Jun 25, 2018

Conversation

omeid
Copy link
Contributor

@omeid omeid commented Apr 22, 2018

This commit adds rule type support so that Rate Limit rules
could be use along with REGULAR rules.

Closes #4079 #4174 #4052

@omeid
resources/wafregional_web_acl: add rule type support
970a6c9 
This commit adds rule type support so that Rate Limit rules
could be use along with REGULAR rules.

Closes hashicorp#4079 hashicorp#4174 hashicorp#4052
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 22, 2018
@bflad bflad added service/waf Issues and PRs that pertain to the waf service. enhancement Requests to existing resources that expand the functionality or scope. labels Apr 23, 2018
@bflad
Copy link
Contributor

bflad commented Apr 23, 2018

Thanks for this @omeid! Are you able to add an acceptance test for this as well?

@omeid
Copy link
Contributor Author

omeid commented Apr 27, 2018

Thanks @bflad, I will look into adding tests. It may take a while as I am unfamiliar with the test structure and time poor atm, sorry about that.

@oba11
Copy link

oba11 commented Jun 6, 2018

Would be great if we can have this PR merged, breaking for users with rate-based rules.

@omeid
Copy link
Contributor Author

omeid commented Jun 7, 2018

@oba11 If you could help add tests, that would be great. I would like this landed too, but very time poor :(

@bflad bflad mentioned this pull request Jun 25, 2018
Merged
@bflad bflad added this to the v1.25.0 milestone Jun 25, 2018
@bflad
Copy link
Contributor

bflad commented Jun 25, 2018

Followup PR (including this commit and associated acceptance test) has been submitted: #4978

@bflad bflad merged commit 970a6c9 into hashicorp:master Jun 25, 2018
bflad added a commit that referenced this pull request Jun 25, 2018
@bflad
Update CHANGELOG for #4307 and #4978
0490212
@bflad
Copy link
Contributor

bflad commented Jun 27, 2018

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.25.0
Development

Successfully merging this pull request may close these issues.

Error adding rate based rule to aws_wafregional_web_acl - type field not recognized
3 participants
@omeid @bflad @oba11