New Resource and Data Source: aws_eks_cluster #4749
Conversation
Also includes EKS Getting Started Guide
bflad
added
new-resource
|
Wow this is the fastest I've seen an AWS service integrated into the terraform provider. Great work and thanks for the prompt update! |
|
FYI I'm just waiting for the official EKS User Guide to be published so I can verify some pieces of the getting started guide. Some pieces might have changed between preview and general availability. |
…rror found during acceptance testing
| }, | ||
| }, | ||
| }, | ||
| "created_at": { |
There was a problem hiding this comment.
Is this field actually useful for anyone/anything? Not a big deal if not, but I thought historically we avoided encoding fields which aren't useful from user's perspective to the schema.
| // InvalidParameterException: The provided role doesn't have the Amazon EKS Managed Policies associated with it. Please ensure the following policies [arn:aws:iam::aws:policy/AmazonEKSClusterPolicy, arn:aws:iam::aws:policy/AmazonEKSServicePolicy] are attached | ||
| if isAWSErr(err, eks.ErrCodeInvalidParameterException, "The provided role doesn't have the Amazon EKS Managed Policies associated with it") { | ||
| return resource.RetryableError(err) | ||
| } |
| } | ||
| // Sometimes the EKS API returns the ResourceNotFound error in this form: | ||
| // ClientException: No cluster found for name: tf-acc-test-0o1f8 | ||
| if isAWSErr(err, eks.ErrCodeClientException, "No cluster found for name:") { |
aws/resource_aws_eks_cluster_test.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func TestAccAWSEksCluster_Basic(t *testing.T) { |
There was a problem hiding this comment.
Nitpick, but AFAIK all our tests use _basic, not _Basic.
|
|
||
| conn := testAccProvider.Meta().(*AWSClient).eksconn | ||
|
|
||
| // Handle eventual consistency |
| manage or retrieve data from other AWS services. It is also possible to create | ||
| these policies with the [`aws_iam_policy_document` data source](/docs/providers/aws/d/iam_policy_document.html) | ||
|
|
||
| For the latest required policy, see the EKS User Guide. |
There was a problem hiding this comment.
Nitpick, but link to the EKS User Guide may be useful here.
There was a problem hiding this comment.
Ha! Great catch. I was waiting for the official URL. I'll add it.
| locals { | ||
| kubeconfig = <<KUBECONFIG | ||
|
|
||
|
|
There was a problem hiding this comment.
Are the two empty lines desired here?
There was a problem hiding this comment.
When I was developing the original demo configuration, the extra lines were helpful for distinguishing the "config" output from the "TF" output in the terminal. I don't think they'll hurt anything being in here still.
| to allow worker nodes to join the cluster. It is also possible to create | ||
| these policies with the [`aws_iam_policy_document` data source](/docs/providers/aws/d/iam_policy_document.html) | ||
|
|
||
| For the latest required policy, see the EKS User Guide. |
There was a problem hiding this comment.
Likewise, link to the user guide would be nice to have.
| data "aws_ami" "eks-worker" { | ||
| filter { | ||
| name = "name" | ||
| values = ["eks-worker-*"] |
There was a problem hiding this comment.
Just curious - this is version agnostic intentionally? i.e. is the data source always going to fetch a valid AMI regardless of the K8S version (currently 1.10)?
There was a problem hiding this comment.
I think we can address this at a later time by updating the various pieces that might be version specific. 👍 Currently the guide is version agnostic.
|
|
||
| While managing the underlying Kubernetes cluster configuration is beyond the | ||
| scope of this guide, we provide an example of how to apply the required | ||
| Kubernetes `ConfigMap` via `kubectl` below for completeness. |
There was a problem hiding this comment.
A link to Config Map would be nice to have here.
https://cloud.google.com/kubernetes-engine/docs/concepts/configmap
There was a problem hiding this comment.
http://kubernetes.io/docs/user-guide/configmap/ would be better IMO
There was a problem hiding this comment.
FYI we'll update the link to the one from @errm post-merge 👍
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Closes #2473
Changes proposed in this pull request:
aws_eks_clusteraws_eks_clusterOutput from acceptance testing: