codedeploy_deployment_group: Include autoscaling groups when updating blue green config.

[niclic]

Fixes #2233

Changes proposed in this pull request:

• Include autoscaling_groups in the UpdateDeploymentGroup request if blue_green_deployment_config has changed.

When updating blue_green_deployment_config with the green_fleet_provisioning_option of COPY_AUTO_SCALING_GROUP, but there are no changes to autoscaling_groups, then the UpdateDeploymentGroup request sent to AWS does not include the list of existing autoScalingGroups and the following error is returned:

InvalidBlueGreenDeploymentConfigurationException: Exactly one AutoScaling group must be specifed when selecting the COPY_AUTO_SCALING_GROUP green fleet provisioning option.

The commit of interest is this one.

I thought this problem might also affect load_balancer_info when using a deployment_option of WITH_TRAFFIC_CONTROL, but it does not appear to.

I added some additional test cases, and also extracted out common retry error handling into a separate function.

[niclic]

Build says:

gofmt needs running on the following files:
./aws/resource_aws_codedeploy_deployment_group_test.go

And yet, it has been run (can't run tests without running make fmt). Even now, I run gofmt but no changes are made to this file. No pending changes or commits.

[niclic]

After reading the docs, I needed to bump my go version to 1.11. ;)

[bflad]

LGTM, thanks @niclic! 🚀

31 tests passed (all tests)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (21.42s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (23.82s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (25.36s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (28.20s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (29.31s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (29.52s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (31.64s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (32.29s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (32.70s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (35.97s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (39.98s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (40.88s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (21.33s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (24.71s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (50.57s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_create (21.16s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (57.76s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (22.39s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (26.43s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (21.06s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (33.45s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (61.90s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_update (33.99s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (66.44s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (66.96s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (74.00s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (85.65s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (60.85s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (104.40s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg (133.67s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (185.39s)

[ghost]

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "aws" {
	version = "~> 1.39.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!