Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Amazon SNS server-side encryption #6502

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Add support for Amazon SNS server-side encryption #6502

merged 1 commit into from
Nov 19, 2018

Conversation

ewbankkit
Copy link
Contributor

Fixes #6491.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSNSTopic_encryption'==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSSNSTopic_encryption -timeout 120m
=== RUN   TestAccAWSSNSTopic_encryption
=== PAUSE TestAccAWSSNSTopic_encryption
=== CONT  TestAccAWSSNSTopic_encryption
--- PASS: TestAccAWSSNSTopic_encryption (22.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.952s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/sns Issues and PRs that pertain to the sns service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 16, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 19, 2018
bflad
bflad approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in, thanks so much @ewbankkit 🚀

--- PASS: TestAccAWSSNSTopic_name (4.44s)
--- PASS: TestAccAWSSNSTopic_basic (4.48s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (4.48s)
--- PASS: TestAccAWSSNSTopic_namePrefix (4.53s)
--- PASS: TestAccAWSSNSTopic_policy (4.61s)
--- PASS: TestAccAWSSNSTopic_importBasic (5.06s)
--- PASS: TestAccAWSSNSTopic_encryption (6.93s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (20.80s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (22.52s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (63.18s)

website/docs/r/sns_topic.html.markdown
@@ -64,6 +73,7 @@ The following arguments are supported:
* `http_success_feedback_role_arn` - (Optional) The IAM role permitted to receive success feedback for this topic
* `http_success_feedback_sample_rate` - (Optional) Percentage of success to sample
* `http_failure_feedback_role_arn` - (Optional) IAM role for failure feedback
* `kms_master_key_id` - (Optional) The ID of an AWS-managed customer master key (CMK) for Amazon SNS or a custom CMK. For more information, see [Key Terms](https://docs.aws.amazon.com/sns/latest/dg/sns-server-side-encryption.html#sse-key-terms)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We should probably note this as ID or ARN, as both are allowed.

@bflad bflad added this to the v1.46.0 milestone Nov 19, 2018
@bflad bflad merged commit e76a14b into hashicorp:master Nov 19, 2018
bflad added a commit that referenced this pull request Nov 19, 2018
@bflad
Update CHANGELOG for #6502
8be8a8e
@bflad
Copy link
Contributor

bflad commented Nov 20, 2018

This has been released in version 1.46.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ewbankkit ewbankkit deleted the issue-6491 branch December 16, 2018 22:36
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.46.0
Development

Successfully merging this pull request may close these issues.

Feature request: Amazon SNS server-side encryption
2 participants
@ewbankkit @bflad