Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove maximum=1 for cloudwatch destination #6690

Merged
merged 2 commits into from
Dec 3, 2018
Merged

remove maximum=1 for cloudwatch destination #6690

merged 2 commits into from
Dec 3, 2018

Conversation

david-wells-1
Copy link
Contributor

@david-wells-1 david-wells-1 commented Dec 3, 2018

Fixes #6689
Fixes #5620

Changes proposed in this pull request:

  • Change 1
  • Change 2

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'

...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ses Issues and PRs that pertain to the ses service. labels Dec 3, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @david-wells-1 👋 Thanks for submitting this! Could you please also update the existing acceptance testing to include multiple CloudWatch destinations to prevent regressions in the future? e.g. copy pasting this test configuration with a slight update:

https://github.com/terraform-providers/terraform-provider-aws/blob/e5c1c5158a413e6d95a912d93093b47e0cc5b3ca/aws/resource_aws_ses_event_destination_test.go#L201

@ghost ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 3, 2018
@david-wells-1
Copy link
Contributor Author

@bflad - additional test added as requested for the ses_destination_event

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 3, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 3, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @david-wells-1! 🚀

This Terraform resource is very strange and does not have a Read implementation. While it doesn't look like the SES API has not changed in this regard from my brief searching, I was able to confirm via the acceptance testing with debug SDK logging that multiple destinations were appropriately set and that the SES API accepted this configuration.

--- PASS: TestAccAWSSESEventDestination_basic (93.89s)

@bflad bflad merged commit 88f8e58 into hashicorp:master Dec 3, 2018
@david-wells-1
Copy link
Contributor Author

Thanks @bflad

bflad added a commit that referenced this pull request Dec 3, 2018
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants