Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/codebuild: Enable Github Enterprise Report Build Status #6929

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

gthole
Copy link
Contributor

@gthole gthole commented Dec 19, 2018

Changes proposed in this pull request:

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub* -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (27.50s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (27.534s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 19, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 19, 2018
@bflad bflad added this to the v1.53.0 milestone Dec 19, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, thanks @gthole! 🚀

--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (17.76s)
--- PASS: TestAccAWSCodeBuildProject_basic (18.00s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (18.16s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (18.58s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (18.77s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (18.92s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (22.01s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (22.17s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (22.76s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (23.00s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (23.29s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (7.31s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (25.70s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (26.34s)
--- PASS: TestAccAWSCodeBuildProject_importBasic (26.45s)
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (26.98s)
--- PASS: TestAccAWSCodeBuildProject_Description (30.00s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (30.28s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (30.45s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (15.96s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (35.55s)
--- PASS: TestAccAWSCodeBuildProject_Cache (35.60s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (16.55s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (17.03s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (24.07s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (24.38s)
--- PASS: TestAccAWSCodeBuildProject_Tags (28.81s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (35.28s)

@bflad bflad merged commit 3c42675 into hashicorp:master Dec 19, 2018
bflad added a commit that referenced this pull request Dec 19, 2018
@bflad
Copy link
Contributor

bflad commented Dec 19, 2018

This will release with version 1.53.0 of the AWS provider, likely tomorrow. 👍

@bflad
Copy link
Contributor

bflad commented Dec 20, 2018

This has been released in version 1.53.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants