Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_vpn_connection: Remove configurability of read-only customer_gateway_configuration, routes, and vgw_telemetry attributes #7636

Merged
merged 1 commit into from
Feb 26, 2019
Merged

resource/aws_vpn_connection: Remove configurability of read-only customer_gateway_configuration, routes, and vgw_telemetry attributes #7636

merged 1 commit into from
Feb 26, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 21, 2019

Fixes #7609

@bflad
resource/aws_vpn_connection: Remove configurability of read-only cust…
5ccaef1 
…omer_gateway_configuration, routes, and vgw_telemetry attributes

Reference: #7609
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 21, 2019
@bflad bflad requested a review from a team February 21, 2019 15:15
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 21, 2019
@bflad bflad mentioned this pull request Feb 21, 2019
Closed
paddycarver
paddycarver approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling out this is a breaking change, but if it's in preparation of a major version bump, that's fine 👍

@bflad bflad added this to the v2.0.0 milestone Feb 26, 2019
@bflad bflad merged commit 55f1682 into master Feb 26, 2019
@bflad bflad deleted the b-aws_vpn_connection-computed-attributes branch February 26, 2019 00:57
bflad added a commit that referenced this pull request Feb 26, 2019
@bflad
Update CHANGELOG for #7636
e389afe
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

How to set VPN outside ip address?
2 participants
@bflad @paddycarver