Feature/fix aws directory service directory creation step

[teraken0509]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7672

Changes proposed in this pull request:

• Add Tags setting in creation request.
• Remove resourceAwsDirectoryServiceDirectoryUpdate calling from Create step.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDirectoryServiceDirectory_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDirectoryServiceDirectory_ -timeout 120m
=== RUN   TestAccAWSDirectoryServiceDirectory_importBasic
=== PAUSE TestAccAWSDirectoryServiceDirectory_importBasic
=== RUN   TestAccAWSDirectoryServiceDirectory_basic
=== PAUSE TestAccAWSDirectoryServiceDirectory_basic
=== RUN   TestAccAWSDirectoryServiceDirectory_tags
=== PAUSE TestAccAWSDirectoryServiceDirectory_tags
=== RUN   TestAccAWSDirectoryServiceDirectory_microsoft
=== PAUSE TestAccAWSDirectoryServiceDirectory_microsoft
=== RUN   TestAccAWSDirectoryServiceDirectory_microsoftStandard
=== PAUSE TestAccAWSDirectoryServiceDirectory_microsoftStandard
=== RUN   TestAccAWSDirectoryServiceDirectory_connector
=== PAUSE TestAccAWSDirectoryServiceDirectory_connector
=== RUN   TestAccAWSDirectoryServiceDirectory_withAliasAndSso
=== PAUSE TestAccAWSDirectoryServiceDirectory_withAliasAndSso
=== CONT  TestAccAWSDirectoryServiceDirectory_importBasic
=== CONT  TestAccAWSDirectoryServiceDirectory_microsoftStandard
=== CONT  TestAccAWSDirectoryServiceDirectory_withAliasAndSso
=== CONT  TestAccAWSDirectoryServiceDirectory_tags
=== CONT  TestAccAWSDirectoryServiceDirectory_microsoft
=== CONT  TestAccAWSDirectoryServiceDirectory_basic
=== CONT  TestAccAWSDirectoryServiceDirectory_connector
--- FAIL: TestAccAWSDirectoryServiceDirectory_basic (13.53s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_vpc.main: 1 error occurred:
        	* aws_vpc.main: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
        	status code: 400, request id: 3309e6bb-c298-4ae9-9056-e3616ca61f97




    testing.go:599: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: Default error in Service Directory Test

        State: <no state>
--- FAIL: TestAccAWSDirectoryServiceDirectory_microsoftStandard (13.64s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_vpc.main: 1 error occurred:
        	* aws_vpc.main: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
        	status code: 400, request id: ed8b751b-2b54-4384-bc4c-317d13d7275a




    testing.go:599: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: Default error in Service Directory Test

        State: <no state>
--- PASS: TestAccAWSDirectoryServiceDirectory_importBasic (665.52s)
--- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (701.98s)
--- PASS: TestAccAWSDirectoryServiceDirectory_tags (725.32s)
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (1266.15s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1744.61s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1744.686s
make: *** [testacc] Error 1

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDirectoryServiceDirectory_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDirectoryServiceDirectory_basic -timeout 120m
=== RUN   TestAccAWSDirectoryServiceDirectory_basic
=== PAUSE TestAccAWSDirectoryServiceDirectory_basic
=== CONT  TestAccAWSDirectoryServiceDirectory_basic
--- PASS: TestAccAWSDirectoryServiceDirectory_basic (568.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	568.129s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDirectoryServiceDirectory_microsoftStandard'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDirectoryServiceDirectory_microsoftStandard -timeout 120m
=== RUN   TestAccAWSDirectoryServiceDirectory_microsoftStandard
=== PAUSE TestAccAWSDirectoryServiceDirectory_microsoftStandard
=== CONT  TestAccAWSDirectoryServiceDirectory_microsoftStandard
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1882.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1882.653s

[bflad]

Looks good, thanks @kterada0509! 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDirectoryServiceDirectory_tags (550.31s)
--- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (584.47s)
--- PASS: TestAccAWSDirectoryServiceDirectory_basic (601.18s)
--- PASS: TestAccAWSDirectoryServiceDirectory_importBasic (615.33s)
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (932.17s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1689.74s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1823.46s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1708.50s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1728.72s)

[bflad]

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!