Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_organizations_organization: Add accounts attribute #8581

Merged
merged 1 commit into from
May 9, 2019
Merged

resource/aws_organizations_organization: Add accounts attribute #8581

merged 1 commit into from
May 9, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 9, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8579

Release note for CHANGELOG:

resource/aws_organizations_organization: Add accounts attribute

Output from acceptance testing:

    --- PASS: TestAccAWSOrganizations/Organization (49.62s)
        --- PASS: TestAccAWSOrganizations/Organization/basic (14.16s)
        --- PASS: TestAccAWSOrganizations/Organization/AwsServiceAccessPrincipals (25.03s)
        --- PASS: TestAccAWSOrganizations/Organization/FeatureSet (10.43s)

@bflad
resource/aws_organizations_organization: Add accounts attribute
12ef4b0 
Reference: #8579

Output from acceptance testing:

```
    --- PASS: TestAccAWSOrganizations/Organization (49.62s)
        --- PASS: TestAccAWSOrganizations/Organization/basic (14.16s)
        --- PASS: TestAccAWSOrganizations/Organization/AwsServiceAccessPrincipals (25.03s)
        --- PASS: TestAccAWSOrganizations/Organization/FeatureSet (10.43s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service. labels May 9, 2019
@bflad bflad requested a review from a team May 9, 2019 03:13
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels May 9, 2019
@bflad bflad mentioned this pull request May 9, 2019
Closed
nywilken
nywilken approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@bflad bflad added this to the v2.10.0 milestone May 9, 2019
@bflad bflad merged commit 6b033e0 into master May 9, 2019
@bflad bflad deleted the f-aws_organizations_organization-accounts branch May 9, 2019 23:49
bflad added a commit that referenced this pull request May 9, 2019
@bflad
Update CHANGELOG for #8581
2121306
@bflad
Copy link
Contributor Author

bflad commented May 10, 2019

This has been released in version 2.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Add Account Information to aws_organizations_organization Resource
2 participants
@bflad @nywilken