Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/codebuild: Increase timeout for creation retry (IAM) #904

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

radeksimko
Copy link
Member

This is to address the following test failure:

=== RUN   TestAccAWSCodeBuildProject_basic
--- FAIL: TestAccAWSCodeBuildProject_basic (15.12s)
    testing.go:428: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_codebuild_project.foo: 1 error(s) occurred:
        
        * aws_codebuild_project.foo: [ERROR] Error updating CodeBuild project (arn:aws:codebuild:us-west-2:*******:project/test-project-6kum6jemzb): InvalidInputException: CodeBuild is not authorized to perform: sts:AssumeRole on arn:aws:iam::*******:role/codebuild-role-6kum6jemzb
            status code: 400, request id: 4f535692-5320-11e7-8006-2d816cc1e349

I'm aware this may uncover some other errors, but I think it's better to scope down the retry to specific error codes rather than blindly retry on any error and delay displaying genuine user errors.

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jun 19, 2017
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 289be94 into master Jun 19, 2017
@radeksimko radeksimko deleted the b-codebuild-iam branch June 19, 2017 11:40
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants