Add support import for aws_waf_rule_group resource

[teraken0509]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference #9212

Release note for CHANGELOG:

resource/aws_waf_rule_group: Support resource import

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSWafRuleGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSWafRuleGroup_ -timeout 120m
=== RUN   TestAccAWSWafRuleGroup_basic
=== PAUSE TestAccAWSWafRuleGroup_basic
=== RUN   TestAccAWSWafRuleGroup_changeNameForceNew
=== PAUSE TestAccAWSWafRuleGroup_changeNameForceNew
=== RUN   TestAccAWSWafRuleGroup_disappears
=== PAUSE TestAccAWSWafRuleGroup_disappears
=== RUN   TestAccAWSWafRuleGroup_changeActivatedRules
=== PAUSE TestAccAWSWafRuleGroup_changeActivatedRules
=== RUN   TestAccAWSWafRuleGroup_noActivatedRules
=== PAUSE TestAccAWSWafRuleGroup_noActivatedRules
=== CONT  TestAccAWSWafRuleGroup_basic
=== CONT  TestAccAWSWafRuleGroup_disappears
=== CONT  TestAccAWSWafRuleGroup_changeActivatedRules
=== CONT  TestAccAWSWafRuleGroup_noActivatedRules
=== CONT  TestAccAWSWafRuleGroup_changeNameForceNew
--- FAIL: TestAccAWSWafRuleGroup_changeNameForceNew (31.18s)
    testing.go:568: Step 0 error: errors during apply:

        Error: WAFLimitsExceededException: Operation would result in exceeding resource limits.
        	status code: 400, request id: c223e71f-9f9f-11e9-b8f1-7d8164ac8db6

          on /var/folders/w9/yq_zm9bj24z06tlty8163139j7txby/T/tf-test327365376/main.tf line 7:
          (source code not available)


--- FAIL: TestAccAWSWafRuleGroup_disappears (33.42s)
    testing.go:568: Step 0 error: errors during apply:

        Error: WAFLimitsExceededException: Operation would result in exceeding resource limits.
        	status code: 400, request id: c3148954-9f9f-11e9-a420-835668605bb5

          on /var/folders/w9/yq_zm9bj24z06tlty8163139j7txby/T/tf-test402598450/main.tf line 7:
          (source code not available)


--- PASS: TestAccAWSWafRuleGroup_noActivatedRules (35.92s)
--- PASS: TestAccAWSWafRuleGroup_basic (58.25s)
--- PASS: TestAccAWSWafRuleGroup_changeActivatedRules (89.01s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	89.107s
make: *** [testacc] Error 1

[bflad]

LGTM, thanks @kterada0509 🚀

--- PASS: TestAccAWSWafRuleGroup_disappears (18.18s)
--- PASS: TestAccAWSWafRuleGroup_noActivatedRules (22.57s)
--- PASS: TestAccAWSWafRuleGroup_changeActivatedRules (49.14s)
--- PASS: TestAccAWSWafRuleGroup_changeNameForceNew (54.92s)
--- PASS: TestAccAWSWafRuleGroup_basic (55.68s)

[bflad]

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!