Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retry when creating SES domain identity verification #9417

Merged
merged 2 commits into from
Jul 25, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* aws/ses_domain_identity_verification: Retry after timeout when creating SES domain identity verification

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAwsSesDomainIdentityVerification"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsSesDomainIdentityVerification -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsSesDomainIdentityVerification_basic
--- SKIP: TestAccAwsSesDomainIdentityVerification_basic (0.00s)
    resource_aws_ses_domain_identity_verification_test.go:20: Environment variable SES_DOMAIN_IDENTITY_ROOT_DOMAIN is not set. For DNS verification requests, this domain must be publicly accessible and configurable via Route53 during the testing. 
=== RUN   TestAccAwsSesDomainIdentityVerification_timeout
=== PAUSE TestAccAwsSesDomainIdentityVerification_timeout
=== RUN   TestAccAwsSesDomainIdentityVerification_nonexistent
=== PAUSE TestAccAwsSesDomainIdentityVerification_nonexistent
=== CONT  TestAccAwsSesDomainIdentityVerification_timeout
=== CONT  TestAccAwsSesDomainIdentityVerification_nonexistent
--- PASS: TestAccAwsSesDomainIdentityVerification_nonexistent (11.50s)
--- PASS: TestAccAwsSesDomainIdentityVerification_timeout (21.79s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       22.645s

@ryndaniels ryndaniels requested a review from a team July 19, 2019 11:13
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ses Issues and PRs that pertain to the ses service. labels Jul 19, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jul 23, 2019
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 23, 2019
@ryndaniels ryndaniels requested a review from bflad July 25, 2019 08:31
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

--- SKIP: TestAccAwsSesDomainIdentityVerification_basic (0.00s)
--- PASS: TestAccAwsSesDomainIdentityVerification_nonexistent (3.63s)
--- PASS: TestAccAwsSesDomainIdentityVerification_timeout (9.66s)

@ryndaniels ryndaniels removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 25, 2019
@ryndaniels ryndaniels added this to the v2.21.0 milestone Jul 25, 2019
@ryndaniels ryndaniels merged commit cbbe12b into master Jul 25, 2019
@ryndaniels ryndaniels deleted the rfd-retry-ses branch July 25, 2019 16:43
@bflad
Copy link
Contributor

bflad commented Jul 26, 2019

This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ses Issues and PRs that pertain to the ses service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants