Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support import for aws_wafregional_ipset resource #9424

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

lpfeup
Copy link
Contributor

@lpfeup lpfeup commented Jul 19, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9397

Release note for CHANGELOG:

resource/aws_wafregional_ipset: Support resource import

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSWafRegionalIPSet'
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSWafRegionalIPSet -timeout 120m
=== RUN   TestAccAWSWafRegionalIPSet_basic
=== PAUSE TestAccAWSWafRegionalIPSet_basic
=== RUN   TestAccAWSWafRegionalIPSet_disappears
=== PAUSE TestAccAWSWafRegionalIPSet_disappears
=== RUN   TestAccAWSWafRegionalIPSet_changeNameForceNew
=== PAUSE TestAccAWSWafRegionalIPSet_changeNameForceNew
=== RUN   TestAccAWSWafRegionalIPSet_changeDescriptors
=== PAUSE TestAccAWSWafRegionalIPSet_changeDescriptors
=== RUN   TestAccAWSWafRegionalIPSet_IpSetDescriptors_1000UpdateLimit
=== PAUSE TestAccAWSWafRegionalIPSet_IpSetDescriptors_1000UpdateLimit
=== RUN   TestAccAWSWafRegionalIPSet_noDescriptors
=== PAUSE TestAccAWSWafRegionalIPSet_noDescriptors
=== CONT  TestAccAWSWafRegionalIPSet_basic
=== CONT  TestAccAWSWafRegionalIPSet_noDescriptors
=== CONT  TestAccAWSWafRegionalIPSet_IpSetDescriptors_1000UpdateLimit
=== CONT  TestAccAWSWafRegionalIPSet_changeDescriptors
=== CONT  TestAccAWSWafRegionalIPSet_changeNameForceNew
=== CONT  TestAccAWSWafRegionalIPSet_disappears
--- PASS: TestAccAWSWafRegionalIPSet_noDescriptors (24.72s)
--- PASS: TestAccAWSWafRegionalIPSet_disappears (26.56s)
--- PASS: TestAccAWSWafRegionalIPSet_basic (38.56s)
--- PASS: TestAccAWSWafRegionalIPSet_changeDescriptors (51.53s)
--- PASS: TestAccAWSWafRegionalIPSet_changeNameForceNew (56.63s)
--- PASS: TestAccAWSWafRegionalIPSet_IpSetDescriptors_1000UpdateLimit (86.18s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       86.236s
...

@lpfeup lpfeup requested a review from a team July 19, 2019 20:39
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 19, 2019
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @lpfeup, thank you! 🚀

--- PASS: TestDiffWafRegionalIpSetDescriptors (0.00s)
--- PASS: TestAccAWSWafRegionalIPSet_noDescriptors (11.16s)
--- PASS: TestAccAWSWafRegionalIPSet_basic (18.73s)
--- PASS: TestAccAWSWafRegionalIPSet_changeDescriptors (24.21s)
--- PASS: TestAccAWSWafRegionalIPSet_disappears (24.53s)
--- PASS: TestAccAWSWafRegionalIPSet_changeNameForceNew (40.81s)
--- PASS: TestAccAWSWafRegionalIPSet_IpSetDescriptors_1000UpdateLimit (70.77s)

@ryndaniels ryndaniels added this to the v2.21.0 milestone Jul 22, 2019
@ryndaniels ryndaniels merged commit d384ffc into hashicorp:master Jul 22, 2019
bflad added a commit that referenced this pull request Jul 26, 2019
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import aws_wafregional_ipset resource
4 participants