Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose status property on EKS clusters #9582

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

svangordon
Copy link
Contributor

Expose the status attribute on EKS clusters.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Expose status attribute on EKS clusters

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run="TestAccAWSEksClusterDataSource_basic|TestAccAWSEksCluster_basic"'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run="TestAccAWSEksClusterDataSource_basic|TestAccAWSEksCluster_basic" -timeout 120m
=== RUN   TestAccAWSEksClusterDataSource_basic
=== PAUSE TestAccAWSEksClusterDataSource_basic
=== RUN   TestAccAWSEksCluster_basic
=== PAUSE TestAccAWSEksCluster_basic
=== CONT  TestAccAWSEksClusterDataSource_basic
=== CONT  TestAccAWSEksCluster_basic
--- PASS: TestAccAWSEksCluster_basic (1269.69s)
--- PASS: TestAccAWSEksClusterDataSource_basic (1316.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1316.922s

@svangordon svangordon requested a review from a team August 1, 2019 01:09
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 1, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 1, 2019
@bflad bflad added this to the v2.23.0 milestone Aug 2, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSEksClusterAuthDataSource_basic (9.64s)
--- PASS: TestAccAWSEksCluster_basic (1147.75s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1168.54s)
--- PASS: TestAccAWSEksCluster_Logging (1210.46s)
--- PASS: TestAccAWSEksClusterDataSource_basic (1340.31s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1654.73s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (1696.50s)
--- PASS: TestAccAWSEksCluster_Version (2392.29s)

@bflad bflad merged commit fbff3d1 into hashicorp:master Aug 2, 2019
bflad added a commit that referenced this pull request Aug 2, 2019
@ghost
Copy link

ghost commented Aug 7, 2019

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants