New Resources: aws_fsx_lustre_file_system and aws_fsx_windows_file_system

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7035
Closes #7074

Release note for CHANGELOG:

* **New Resource:** `aws_fsx_lustre_file_system`
* **New Resource:** `aws_fsx_windows_file_system`

Builds on #7074 with the following changes (special thanks to @slapula who put an incredible amount of work up until this point):

• Split into two separate resources (aws_fsx_lustre_file_system and aws_fsx_windows_file_system) to simplify practitioner configuration (e.g. lose the required configuration blocks), ease maintenance for resource logic and single file system arguments (e.g. kms_key_id only for Windows), and enhance validations (e.g. storage_capacity differences between file systems)
• Add covering acceptance testing with updates/force new for all arguments
• Better alignment with API naming for some arguments (e.g. changing capacity into storage_capacity to remove ambiguity with throughput_capacity)
• Implement resource Customizable Timeouts
• Implement skip_final_backup argument for Windows
• Implement network_interface_ids, owner_id, and vpc_id attributes
• Augment resource documentation with additional notes found in API reference and clarify security_group_ids import behavior

Output from acceptance testing:

--- PASS: TestAccAWSFsxLustreFileSystem_Tags (458.62s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (526.79s)
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (564.58s)
--- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (697.83s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (940.13s)
--- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (1074.08s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (1276.18s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportPath (1322.13s)
--- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (1338.75s)

--- PASS: TestAccAWSFsxWindowsFileSystem_Tags (2256.64s)
--- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (2346.44s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (2404.35s)
--- PASS: TestAccAWSFsxWindowsFileSystem_disappears (2412.10s)
--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (2514.61s)
--- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (2849.43s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (2850.64s)
--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (3292.44s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (3609.37s)
--- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (3977.10s)
--- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (4026.67s)
--- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (4389.57s)

[ryndaniels]

LGTM! 🚀

[slapula]

Thanks for the help getting this over the finish line. This approach makes a lot of sense and I completely forgot about custom timeout stuff. This is awesome! (And it frees me up to work on adding support for Ground Station)

[bflad]

@slapula thank you so much for your work on this! ❤️ Would not have been possible without your support. My apologies that we wanted to get this released a little sooner than going through the various items above with you, which might have been challenging to convey via one-off review comments. We are discussing setting up some other forms of more real-time collaboration for this project in general to help solve this problem for development questions and more complicated review items (e.g. community office hours and/or provider development Slack channel). We would love to know if you would potentially be interested in something like that (if not, no big deal either). 😄

If you have any questions about anything here, please reach out and I'll be happy to answer. Thanks again for making this happen.

[slapula]

@bflad Yes, I would definitely be interested! I use Slack regularly so that's my preferred option but I'm open to other venues as well. I'll be at Hashiconf so perhaps we can discuss this in person.

[ghost]

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[onur-sam-gtn-ai]

It seems like import has let me down.

# aws_fsx_lustre_file_system.lustre[0] must be replaced
-/+ resource "aws_fsx_lustre_file_system" "lustre" {
      ~ arn                           = "redacted" -> (known after apply)
      ~ dns_name                      = "redacted.amazonaws.com" -> (known after apply)
        export_path                   = "s3://redacted"
      ~ id                            = "fs-redacted" -> (known after apply)
        import_path                   = "s3://redacted"
      ~ imported_file_chunk_size      = 2048 -> (known after apply)
      ~ network_interface_ids         = [
          - "eni-redacted",
          - "eni-redacted",
        ] -> (known after apply)
      ~ owner_id                      = "redacted" -> (known after apply)
      + security_group_ids            = [
          + "SAME SG ID AS THE ONE ALREADY ON THE FSx",
        ] # forces replacement

[onur-sam-gtn-ai]

State file indeed says "security_group_ids": null

[onur-sam-gtn-ai]

Raised issue #9795 for this.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!