Final retries for elasticsearch domain resources

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_elasticsearch_domain: Final retries after timeouts creating, updating, and deleting domains
* resource/aws_elasticsearch_domain_policy: Final retries after timeouts upserting and deleting domain policies

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSElasticSearchDomainPolicy"      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSElasticSearchDomainPolicy -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSElasticSearchDomainPolicy_basic
=== PAUSE TestAccAWSElasticSearchDomainPolicy_basic
=== CONT  TestAccAWSElasticSearchDomainPolicy_basic
--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (827.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       828.902s

--- PASS: TestAccAWSElasticSearchDomain_duplicate (495.35s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (978.34s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (1163.53s)
--- PASS: TestAccAWSElasticSearchDomain_basic (1240.35s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1265.31s)
--- PASS: TestAccAWSElasticSearchDomain_policy (1301.58s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1549.36s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1692.22s)
--- PASS: TestAccAWSElasticSearchDomain_importBasic (1709.79s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (1927.92s)
--- PASS: TestAccAWSElasticSearchDomain_update (2392.79s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (2592.19s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (2757.88s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3192.70s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (3536.21s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (5295.32s)
--- PASS: TestAccAWSElasticSearchDomain_complex (893.46s)

// Not a new failure on alternate account
--- FAIL: TestAccAWSElasticSearchDomain_vpc_update (73.44s)
--- FAIL: TestAccAWSElasticSearchDomain_vpc (95.88s)
--- FAIL: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (880.45s)

// Not a new failure
--- FAIL: TestAccAWSElasticSearchDomain_update_version (852.79s)

[obourdon]

@ryndaniels do you think this could fix issues like #7725 ? At least for the Authenticationerror case.

[ryndaniels]

@ryndaniels do you think this could fix issues like #7725 ? At least for the Authenticationerror case.

@obourdon unfortunately, probably not in this case! That issue you referenced looks more related to eventual consistency with IAM roles, and is most likely not directly to these fixes, which are addressing timeouts with API calls specifically.

[obourdon]

@ryndaniels many thanks for this answer. This makes perfect sense.

The reason I was asking is because the issue #7725 seems to be transient as relaunching deployment right after seems to work each and every time and I was suspecting that the number of retries/timeout could be responsible for this.

I made a trial fix in my terraform-provider-aws code but again as this issue is transient I can not
easily plug this in our CI and I am hoping to see my fix work whenever I deploy manually which is not so frequently these days.

BTW, could you please also have a look at PR #3911 (other timeout issue) or ask someone to have a look at it. We have been using this fix in our own fork of terraform-provider-aws for quite some time now and would like to use the official delivery once it gets integrated.

Many thanks again and best regards

[ryndaniels]

@obourdon thanks for this context! As was mentioned in the conversation on #3911, those sorts of changes do often require internal discussion before implementing. We understand that this can be frustrating, but we'd ask for your patience here - please rest assured that this is on our radar to look at!

[aeschright]

Slow tests but they go → 🐌 🚀

--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (1233.20s)
--- PASS: TestAccAWSElasticSearchDomain_duplicate (477.85s)
--- PASS: TestAccAWSElasticSearchDomain_policy (869.11s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (883.17s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (932.54s)
--- PASS: TestAccAWSElasticSearchDomain_basic (997.25s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (997.71s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (1000.61s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1059.06s)
--- PASS: TestAccAWSElasticSearchDomain_complex (584.27s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (1209.86s)
--- PASS: TestAccAWSElasticSearchDomain_importBasic (1325.83s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1337.66s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1358.54s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (1400.17s)
--- PASS: TestAccAWSElasticSearchDomain_update (1473.11s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2226.93s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (2392.38s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (2453.51s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (3026.81s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (3307.56s)

Expected:

--- FAIL: TestAccAWSElasticSearchDomain_update_version (981.18s)

[ghost]

This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!