Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application_password: deprecate application_id in favour of application_object_id #107

Merged
merged 8 commits into from
Jun 12, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jun 10, 2019

fixes #106

given there is both application.object_id and application.application_id this should bring some clarity and hopefully prevent confusion.

@ghost ghost added size/L and removed size/M labels Jun 10, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katbyte katbyte closed this Jun 12, 2019
@katbyte katbyte deleted the app/password_app_id branch June 12, 2019 19:04
@katbyte katbyte restored the app/password_app_id branch June 12, 2019 19:14
@katbyte katbyte reopened this Jun 12, 2019
@katbyte katbyte merged commit 6ebea62 into master Jun 12, 2019
@katbyte katbyte deleted the app/password_app_id branch June 12, 2019 19:42
katbyte added a commit that referenced this pull request Jun 12, 2019
@ghost
Copy link

ghost commented Jul 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_application_password object_id argument vs documentation
2 participants