Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hamilton: Fix Azure CLI auth detection & Service Principal marshaling #539

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Update Hamilton: Fix Azure CLI auth detection & Service Principal marshaling #539

merged 2 commits into from
Sep 1, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Aug 31, 2021 •
edited
Loading

  • Fix detection of Azure CLI authorizer to accommodate CachedAuthorizer
  • Hamilton update also includes a marshaling bug fix for the ServicePrincipal model struct

NOTE: Before merging this needs rebasing to use a proper Hamilton release

Fixes: #529
Fixes: #530

@manicminer manicminer added this to the v2.1.0 milestone Aug 31, 2021
@manicminer manicminer requested a review from a team August 31, 2021 11:18
@manicminer manicminer changed the base branch from main to deps/hamilton-0.25.0 September 1, 2021 08:20
@github-actions github-actions bot added size/M and removed size/XL labels Sep 1, 2021
Base automatically changed from deps/hamilton-0.25.0 to main September 1, 2021 08:40
jackofallops
jackofallops approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer changed the title Fix Azure CLI auth detection Update Hamilton: Fix Azure CLI auth detection & Service Principal marshaling Sep 1, 2021
@manicminer
Copy link
Contributor Author

(Rebased to vendor a proper Hamilton release)

@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-09-01 at 16 06 18

@manicminer manicminer merged commit 6c61040 into main Sep 1, 2021
@manicminer manicminer deleted the bugfix/cli-auth-detection branch September 1, 2021 15:36
manicminer added a commit that referenced this pull request Sep 1, 2021
@manicminer
Changelog for #539
1b0b97c
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
authentication bug dependencies size/M
Projects
None yet
Milestone
v2.1.0
2 participants
@manicminer @jackofallops