-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: deprecate skip_credentials_validation
#10464
provider: deprecate skip_credentials_validation
#10464
Conversation
This field got added to allow people to input fake data to get `terraform validate` working - which is fine but some people then complained that plan showed invalid data because of it - in short it shouldn’t have been added in the first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @magodo
Thanks for this PR - taking a look through this mostly LGTM - but we'll need to add a deprecation message to the existing field rather than outright removing it for the moment (although the behaviour can be removed, since this hasn't worked since ~2.0 anyway).
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.47.0"
}
# ... other configuration ... |
Hi @magodo . Should this warning be shown evenif the field is not specified explicitly? My main.tf is as below. The
But the message below is shown when
Is this expected? |
Sorry, #10560 means that. (I didn't read this thread enough.) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This field got added to allow people to input fake data to get
terraform validate
working - which is fine but some people then complained that plan showed invalid data because of it - in short it shouldn’t have been added in the first.