Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TemplateSpec Support for Template Deployments #10603

Merged
merged 13 commits into from
Mar 25, 2021

Conversation

jackofallops
Copy link
Member

  • New Resource: azurerm_management_group_template_deployment

  • New Resource: azurerm_tenant_template_deployment

  • New Data Source: azurerm_template_spec_version

  • azurerm_resource_group_template_deployment - add support for template_spec_version_id property

  • azurerm_subscription_template_deployment - add support for template_spec_version_id property

This PR introduces support for deployments from the Template Spec preview by allowing the deployment resources to reference a published Template Spec Version ID, discoverable using the new data source.

@jackofallops jackofallops added this to the v2.49.0 milestone Feb 22, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jackofallops

Thanks for this PR - on the whole this looks pretty good but I've left some comments inline - if we can fix those up then this should otherwise be good to go 👍

Thanks!

@tombuildsstuff tombuildsstuff modified the milestones: v2.49.0, v2.50.0 Feb 25, 2021
@jackofallops jackofallops modified the milestones: v2.52.0, v2.53.0 Mar 18, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@neil-yechenwei
Copy link
Contributor

LGTM 👍

@jackofallops
Copy link
Member Author

Tests look good:
image

@jackofallops jackofallops merged commit dcfbaec into master Mar 25, 2021
jackofallops added a commit that referenced this pull request Mar 25, 2021
@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 2.53.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.53.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 24, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2021
@katbyte katbyte deleted the r/template-spec-deployments branch May 25, 2021 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants