Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to v15 of the Azure SDK for Go #1077

Merged
merged 7 commits into from
Apr 6, 2018
Merged

Upgrading to v15 of the Azure SDK for Go #1077

merged 7 commits into from
Apr 6, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Apr 5, 2018

Tasks:

```
$ acctests azurerm TestAccAzureRMRoleAssignment
=== RUN   TestAccAzureRMRoleAssignment
=== RUN   TestAccAzureRMRoleAssignment/basic
=== RUN   TestAccAzureRMRoleAssignment/basic/roleName
=== RUN   TestAccAzureRMRoleAssignment/basic/builtin
=== RUN   TestAccAzureRMRoleAssignment/basic/custom
=== RUN   TestAccAzureRMRoleAssignment/basic/emptyName
=== RUN   TestAccAzureRMRoleAssignment/import
=== RUN   TestAccAzureRMRoleAssignment/import/basic
=== RUN   TestAccAzureRMRoleAssignment/import/custom
--- PASS: TestAccAzureRMRoleAssignment (446.84s)
    --- PASS: TestAccAzureRMRoleAssignment/basic (113.85s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/roleName (32.06s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/builtin (24.82s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/custom (26.03s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/emptyName (30.94s)
    --- PASS: TestAccAzureRMRoleAssignment/import (332.99s)
        --- PASS: TestAccAzureRMRoleAssignment/import/basic (30.90s)
        --- PASS: TestAccAzureRMRoleAssignment/import/custom (302.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	446.872s
```
```
$ acctests azurerm TestAccAzureRMTemplateDeployment_withOutputs
=== RUN   TestAccAzureRMTemplateDeployment_withOutputs
--- PASS: TestAccAzureRMTemplateDeployment_withOutputs (226.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	226.921s
```
@tombuildsstuff tombuildsstuff changed the title [WIP] Upgrading to v15 of the Azure SDK for Go Upgrading to v15 of the Azure SDK for Go Apr 5, 2018
@tombuildsstuff tombuildsstuff requested review from metacpp, JunyiYi and a team April 5, 2018 20:08
@tombuildsstuff
Copy link
Contributor Author

Fixes #825

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Contributor Author

Acceptance Tests look good 👍

@tombuildsstuff tombuildsstuff merged commit ce7631a into master Apr 6, 2018
@tombuildsstuff tombuildsstuff deleted the sdkv15 branch April 6, 2018 06:09
tombuildsstuff added a commit that referenced this pull request Apr 6, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants