Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_cluster_resource: lower length validation on windows password #10816

Conversation

feliperoveran
Copy link
Contributor

Fixes #10815

@ghost ghost added the size/XS label Mar 3, 2021
@feliperoveran feliperoveran force-pushed the feliperoveran-remove-windows-password-validation branch from e003ac0 to 5fee762 Compare March 3, 2021 19:54
@feliperoveran feliperoveran changed the title kubernetes_cluster_resource: remove length validation on windows password kubernetes_cluster_resource: lower length validation on windows password Mar 3, 2021
Copy link
Collaborator

@favoretti favoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @feliperoveran, LGTM 👍🏻

@katbyte katbyte added this to the v2.50.0 milestone Mar 4, 2021
@katbyte katbyte merged commit 82fcf1a into hashicorp:master Mar 4, 2021
katbyte added a commit that referenced this pull request Mar 4, 2021
@feliperoveran feliperoveran deleted the feliperoveran-remove-windows-password-validation branch March 4, 2021 14:20
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation of windowsProfile password breaks on existing clusters with shorter passwords
4 participants